Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pirita / native executables feature from wasmer-private #3258

Merged
merged 50 commits into from
Nov 2, 2022
Merged

Migrate pirita / native executables feature from wasmer-private #3258

merged 50 commits into from
Nov 2, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Oct 26, 2022

No description provided.

@fschutt fschutt requested a review from syrusakbary as a code owner October 26, 2022 15:33
@fschutt
Copy link
Contributor Author

fschutt commented Oct 26, 2022

Ideally this should be one single patch based on https://github.com/wasmerio/wasmer-private/pull/40 so that it can be applied / reverted later on.

@fschutt fschutt force-pushed the migrate-wasmer-private branch from c90a5a6 to 1e2617c Compare October 26, 2022 15:44
syrusakbary
syrusakbary reviewed Oct 26, 2022
View reviewed changes
lib/c-api/Cargo.toml Outdated Show resolved Hide resolved
@fschutt fschutt force-pushed the migrate-wasmer-private branch from 7c37cc9 to 84feb95 Compare November 1, 2022 12:32
fschutt added 16 commits November 1, 2022 13:33
@fschutt
Fix error in make package not running
d6fb6a1
@fschutt
Rename wasmer_module_new -> wasmer_object_module_new
eb7f14a 
There was a bit of confusion when merging: both wasmer_module_new,
wasmer_object_module_new and wasmer_static_module_new are one and
the same function.
@fschutt
Remove check to prevent both wasi and emscripten imports
ad7937e
@fschutt
Added more debugging for wasmer test
f738e6d
@fschutt
Move test-integration-cli step to front of queue
de7b451
@fschutt
Set the current directory for integration tests
b7cc838
@fschutt
Try to fix unit test again
a7309c0
@fschutt
Fix get_repo_root_path
81974bf
@fschutt
Implemented maximum level of root dir depth to prevent infinite loop
430ed72
@fschutt
Add debugging to see why the CI isn't working
1061360
@fschutt
Fix get_repo_root_path function
786e273
@fschutt
Remove debugging println
9ae02d5
@fschutt
Enable running integration tests on Windows
6d61514
@fschutt
Debug libwasmer path not found
5bf9c69
@fschutt
Use bash on Windows for running scripts
71be0ae
@fschutt
Add explicit target to window integration tests
f7ad826
syrusakbary
syrusakbary reviewed Nov 2, 2022
View reviewed changes
lib/wasi/Cargo.toml Outdated Show resolved Hide resolved
@fschutt
Copy link
Contributor Author

fschutt commented Nov 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 2, 2022

Build succeeded:

  • Code lint

@bors bors bot merged commit 08f47a3 into master Nov 2, 2022
@bors bors bot deleted the migrate-wasmer-private branch November 2, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschutt @syrusakbary